Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup object selector version constraint #1011

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Cleanup object selector version constraint #1011

merged 1 commit into from
Nov 11, 2024

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/kind cleanup
/platform azure

What this PR does / why we need it:
Remove gardener version constraint for controlplane webhook object selector.

Which issue(s) this PR fixes:
Followup cleanup to gardener/gardener#9864.

Special notes for your reviewer:

Release note:

@LucaBernstein LucaBernstein requested review from a team as code owners November 11, 2024 14:56
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2024
@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 11, 2024
kon-angelo
kon-angelo approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 11, 2024
@kon-angelo kon-angelo merged commit 70f830c into gardener:master Nov 11, 2024
17 checks passed
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 11, 2024
@LucaBernstein LucaBernstein deleted the 9864-cleanup-objectselector-version-constraint branch November 12, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaBernstein @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot